Extend validate_bootloader_layout with UEFI-dependent checks#4474
Merged
svartkanin merged 3 commits intoarchlinux:masterfrom Apr 26, 2026
Merged
Extend validate_bootloader_layout with UEFI-dependent checks#4474svartkanin merged 3 commits intoarchlinux:masterfrom
svartkanin merged 3 commits intoarchlinux:masterfrom
Conversation
Add is_uefi parameter and three new validations: Systemd-boot, Efistub and rEFInd require UEFI; Efistub additionally requires a FAT boot partition. Move the rEFInd UEFI-only check out of GlobalMenu so guided.py and Installer silent-install paths get the same coverage.
svartkanin
reviewed
Apr 26, 2026
svartkanin
reviewed
Apr 26, 2026
Replace module-level _UEFI_ONLY_BOOTLOADERS tuple with an is_uefi_only() method on the Bootloader enum, mirroring the existing has_uki_support() / has_removable_support() pattern.
The UEFI flag is a constant system fact for the run, so the validator retrieves it via SysInfo.has_uefi() directly instead of having every caller pass it in. Updates all three call sites in global_menu.py, installer.py and guided.py, and removes the now-unused SysInfo import from guided.py.
Contributor
Author
|
Thanks, agreed. |
svartkanin
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4442. The validator introduced there covered two Limine-specific layout cases; everything else that makes a config unbootable still lived in GlobalMenu._validate_bootloader, which meant the silent / --config path through guided.py and the safety-net call inside Installer._add_limine_bootloader never saw those checks.
This PR grows validate_bootloader_layout with a is_uefi parameter and three checks that were missing or menu-only:
GlobalMenu, guided.py and Installer._add_limine_bootloader now pass SysInfo.has_uefi() as the third argument. No changes to what currently valid configs look like.
Tested in QEMU against 7 scenarios (BIOS and UEFI, happy paths and every new failure branch) - all behave as expected.